All: Remove register keyword v2 #1411
Conversation
|
Merge Conflict found |
|
needs rebase and conflict resolution. |
|
done |
|
This is just personal preference, but I think that treewide changes like this should not be done unless there is some outstanding merit to them. Inline assembly is very fragile, and changes to it should not be part of treewide changes, even if there is merit to them. Register also prevents the programmer from taking the address of variables, so it is not just an extra word like I don't think this is in the codebase, but with things like: Also:
The register keyword is not like const. If you're working on some code that happens to use the register keyword, and it makes sense to remove the register keyword (it almost always does), then you can remove it. |
3 participants
The register keyword has been removed from all files except compiler.h in xf86. In addition to all modern compilers ignoring this keyword, many of their placements were nonsensical (register on a pointer, const, etc). Compiler.h actually seems to use the register keyword with inline asm, so it will remain for now.
Edit: on second review of compiler.h, there are other similar functions that don't use the register keyword, nor does this function actually specify any specific register like the gcc docs say if you want to make use of the register keyword at an ASM level, so I will simply remove it. If anyone is running powerpc let me know if this causes issues.